Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize stations platform code to be string #394

Open
wants to merge 1 commit into
base: develop_debrecated
Choose a base branch
from
Open

Prioritize stations platform code to be string #394

wants to merge 1 commit into from

Conversation

hieuunguyeen
Copy link
Contributor

No description provided.

@hieuunguyeen hieuunguyeen force-pushed the station-platformCode-prioritize-string branch from 5757c0f to 00f6490 Compare July 8, 2019 13:44
iaforek
iaforek suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@iaforek iaforek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is platformCode the same as stopCode. If so we should aim to standardise this. Moreover, a test would be a nice add on. Actually, a must have :)

@hieuunguyeen
Copy link
Contributor Author

@iaforek platformCode is different from stopCode :) some Finnish train stations have both

@iaforek
Copy link
Contributor

iaforek commented Jul 15, 2019

You should add a test. Additionally, you can update description and put more details about what's platform and how it's different from stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iaforek iaforek iaforek requested changes

@jkrueger jkrueger Awaiting requested review from jkrueger

@alapto alapto Awaiting requested review from alapto

Assignees
No one assigned
Labels
PR: Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieuunguyeen @iaforek